2012-07-17 78 views
0

这是是我的DAO类:如何解决这个值java.sql.SQLException:语句参数<number>没有设置

public Map<String, String> issueOrUpdate(Map<String,String> employeeTempcardMap){ 
     SlingDAO slingdao = new SlingDAO(); 
     Map<String, String> issueOrUpdateMap = new HashMap<String, String>(); 
     StringBuffer issueOrReturnTempcardQuery = new StringBuffer(); 
     String empname="",functionkey="",tempcardnumber="",dateofissue="",dateofreturn=""; 
     int empid=0,rowid=0,insertOrUpdateStatus=0; 
     Connection connection = slingdao.getConnection(); 
     PreparedStatement issueOrReturnPS=null; 
     if (connection != null) { 
      try { 
      if(employeeTempcardMap.get("functionkey").toString().equals("issueTempCard")){ 
       empid =Integer.parseInt(employeeTempcardMap.get("empid").toString()); //empname,tempcardnumber,dateofissue,rowid,dateofreturn 
       empname =employeeTempcardMap.get("empname").toString(); 
       tempcardnumber =employeeTempcardMap.get("tempcardnumber").toString(); 
       dateofissue =employeeTempcardMap.get("issuedate").toString(); 
       //System.out.println("11111111111111111111111111111111111"); 
       //System.out.println("empid : "+empid+" : empname: "+empname+" : tempcardnumber : "+tempcardnumber+": dateofissue "+dateofissue+"Status : "+applicationConstants.ISSUED); 

       issueOrReturnTempcardQuery.append(" INSERT INTO acct_tempcardhistory(empid,empname,tempcardnumber,tempcardstatus,issuedate,returndate) "); 
       issueOrReturnTempcardQuery.append(" VALUES(?,?,?,?,?,?) "); 
      }else{ 
       dateofreturn = employeeTempcardMap.get("returndate").toString(); 
       rowid = Integer.parseInt(employeeTempcardMap.get("rowid").toString()); 
       issueOrReturnTempcardQuery.append(" UPDATE acct_tempcardhistory SET tempcardstatus=?,returndate=? "); 
       issueOrReturnTempcardQuery.append(" WHERE id ="+rowid); 
      } 

       issueOrReturnPS = connection.prepareStatement(issueOrReturnTempcardQuery.toString()); 

       if(functionkey.equals("issueTempCard")){ 
        //System.out.println("2222222222222222222222"); 
        issueOrReturnPS.setInt(1, empid); 
        issueOrReturnPS.setString(2,empname.toString().trim()); 
        issueOrReturnPS.setString(3, tempcardnumber.toString().trim()); 
        issueOrReturnPS.setString(4, applicationConstants.ISSUED.toString().trim()); 
        issueOrReturnPS.setString(5, dateofissue.toString().trim()); 
        issueOrReturnPS.setString(6, "".toString().trim()); 
        //issueOrUpdateMap.put("message","Temporary Card has been issued to "+empid); 

       }else { 
        issueOrReturnPS.setString(1, applicationConstants.RETURNED); 
        issueOrReturnPS.setString(2,dateofreturn); 
        //issueOrUpdateMap.put("message","Temporary Card has been Returned by "+empid); 
       } 
       insertOrUpdateStatus = issueOrReturnPS.executeUpdate(); 

       System.out.println(insertOrUpdateStatus + "row(s) affected"); 

       if(insertOrUpdateStatus >0){ 
        issueOrUpdateMap.put("message","Temporary Card has been issued/Returned to "+empid); 
       }else{ 
        issueOrUpdateMap.put("message","Temporary Card has not been issued/Returned to "+empid); 
       } 
       connection.close(); 

       // connection.commit(); 
      } catch (Exception ex) { 
      ex.printStackTrace(); 
      issueOrUpdateMap.put("message","Temporary Card has not been issued/Returned to "+empid); 
      } finally { 
       try { 
       slingdao.closeConnection(connection, null, issueOrReturnPS); 
       } catch (Exception ex) { 
        ex.printStackTrace(); 
       } 
      } 
     } else { 
      issueOrUpdateMap.put("dbmessage","Connection not Established. Please Contact Vendor"); 
     } 
     return issueOrUpdateMap; 
    } 
} 

UPDATE:

堆栈跟踪:

java.sql.SQLException: Statement parameter 3 not set. 
     at com.mysql.jdbc.SQLError.createSQLException(SQLError.java:910) 
     at com.mysql.jdbc.ServerPreparedStatement.serverExecute(ServerPreparedStatement.java:1045) 
     at com.mysql.jdbc.ServerPreparedStatement.executeInternal(ServerPreparedStatement.java:693) 
     at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1404) 
     at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1318) 
     at com.mysql.jdbc.PreparedStatement.executeUpdate(PreparedStatement.java:1303) 
     at org.apache.tomcat.dbcp.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedS 
tatement.java:105) 
     at org.apache.tomcat.dbcp.dbcp.DelegatingPreparedStatement.executeUpdate(DelegatingPreparedS 
tatement.java:105) 
     at com.slingmedia.notifier.dao.TempCardDAO.issueOrUpdate(TempCardDAO.java:158) 
     at com.slingmedia.notifier.servlet.TempCardServlet.doPost(TempCardServlet.java:83) 
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:641) 
     at javax.servlet.http.HttpServlet.service(HttpServlet.java:722) 
     at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.j 
ava:305) 
     at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) 

     at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:225) 
     at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:169) 
     at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) 
     at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:168) 
     at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:98) 
     at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:927) 
     at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) 
     at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) 
     at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:999 
) 
     at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.jav 
a:565) 
     at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1812) 
     at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) 
     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) 
     at java.lang.Thread.run(Thread.java:662) 

当我印刷,我看到所有的价值,但仍然表明,

java.sql.SQLException: Statement parameter <number> not set. 

相同的工作时更新,但它不适用于插入数据时,我也作为一个字符串的日期。

请指导我如何去做或在哪里做mistak?

问候

+0

介意给堆栈跟踪?有关于代码中的行号的说明? – 2012-07-17 08:38:40

+0

请查看更新的stacktrace,它给出了我在DAO方法中调用DAO方法的行号,在DAO中给出了'insertOrUpdateStatus = issueOrReturnPS中的行号。的executeUpdate(); ' – 2012-07-17 08:40:57

回答

2

你忘了functionKey表达式

employeeTempcardMap.get("functionkey").toString(); 

永远不要声明的结果,尤其是从未与虚拟值初始化您的本地变量提前。这只是掩盖了这样的编码问题。如果你有final String functionKey = ...,这种错误在理论上是不可能的。

1

看看这个:

if(functionkey.equals("issueTempCard")){ 

现在考虑您期望的functionkey变量得到的值。你如何期待它等于issueTempCard?为什么创建SQL语句的条件与设置参数的条件不同?为什么你甚至有两个单独的if/else语句?

我强烈建议你重构这个方法 - 如果你让代码更清晰,它会帮助你更容易地发现这样的问题。另外,我强烈建议您使用参数所有值,避免这样的代码:

issueOrReturnTempcardQuery.append(" WHERE id ="+rowid); 
+0

Jon Skeet,您的观点非常有价值,实际上它帮助我解决了这个问题,但是Marko Topolnik提供了代码中的问题,但我真的很喜欢您回答的方式,因此它不会成为勺子喂食。谢谢。 – 2012-07-17 09:02:46

1

您有:

if(functionkey.equals("issueTempCard")){ 
        //System.out.println("2222222222222222222222"); 
        issueOrReturnPS.setInt(1, empid); 
        issueOrReturnPS.setString(2,empname.toString().trim()); 
        issueOrReturnPS.setString(3, tempcardnumber.toString().trim()); 
        issueOrReturnPS.setString(4, applicationConstants.ISSUED.toString().trim()); 
        issueOrReturnPS.setString(5, dateofissue.toString().trim()); 
        issueOrReturnPS.setString(6, "".toString().trim()); 
        //issueOrUpdateMap.put("message","Temporary Card has been issued to "+empid); 

       }else { 
        issueOrReturnPS.setString(1, applicationConstants.RETURNED); 
        issueOrReturnPS.setString(2,dateofreturn); 
        //issueOrUpdateMap.put("message","Temporary Card has been Returned by "+empid); 
       } 

的情况下,否则被调用时,你只设置参数1和2,但你有6个参数!

+0

为什么低调? – Tomer 2012-07-17 08:51:28

+0

sry我没有downvoted,可能是其他人 – 2012-07-17 08:53:52

0

就意味着你要插入预期代码少值...

例 要插入“1,2” 但预计代码3 所以,它应该是“1,2”, 它会工作

相关问题