为什么我在我的数组索引0上遇到了stackoverflow错误

Question

这是我的战士类。我想在这个班上有一批勇士。 这个想法是能够调用像这样的方法 - > warrior.select（1）在哪里它会得到在索引1创建的战士。希望这是有道理的。 请向我解释为什么这个错误正在发生。

Exception in thread "main" java.lang.StackOverflowError 
    at pking.Warrior.<init>(Warrior.java:42) 

代码

package pking; 

public class Warrior { 

    private String name; 
    private int age; 
    private String call; 
    private int attackPower; 
    private String weapon; 

    public Warrior(String myName, int myAge, String myCall, int myAttackPower) { 
     name = myName; 
     age = myAge; 
     call = myCall; 
     attackPower = myAttackPower; 
     weapon = ""; 
     Warrior[] warriors = new Warrior[4]; 
     warriors[0] = new Warrior("Spartacus", 40, "I AM SPARTACUS!", 9000); 
     warriors[1] = new Warrior("Crixus", 35, "CHAMPION OF CAPUA", 8000); 
     warriors[2] = new Warrior("Gannicus", 30, "SLAYER", 8000); 
     warriors[3] = new Warrior("Alexander", 21, "I AM ALEXANDER, THE CODER", 0); 
    } 

    //Prints warriors name 
    public void name() { 
     System.out.println(name); 
    } 

    //Prints warriors age 
    public void age() { 
     System.out.println(age); 
    } 

    //Prints warriors call 
    public void warriorsCall() { 
     System.out.println(call); 
    } 

    //Prints warriors attack power 
    public void attackPower() { 
     System.out.println(attackPower); 
    } 

    //Equips warriors weapon and prints message 
    public void equip(String myWeapon) { 
     weapon = myWeapon; 
     System.out.println("Equiped the: " + weapon); 
    } 

    //Prints warriors weapon 
    public void weapon() { 
     System.out.println(weapon); 
    } 

} 

Answer 1

你的构造函数运行一个无限循环，因为你是递归调用它。检查你的构造这些行：

Warrior[] warriors = new Warrior[4]; 
    warriors[0] = new Warrior("Spartacus", 40, "I AM SPARTACUS!", 9000); 
    warriors[1] = new Warrior("Crixus", 35, "CHAMPION OF CAPUA", 8000); 
    warriors[2] = new Warrior("Gannicus", 30, "SLAYER OF VAGINAS", 8000); 
    warriors[3] = new Warrior("Alexander", 21, "I AM ALEXANDER, THE CODER", 0); 

为您调用相同的构造每个战士阵列项目实例，再次尝试创建数组并初始化项目，继续这样跌下去，直到堆栈溢出。

更好的设计策略是创建一个新类，说Legion，其中将包含的Warrior个集合：

public class Legion { 
    Warrior[] warriors; 

    public Legion() { 
     warriors = new Warrior[4]; 
     warriors[0] = new Warrior("Spartacus", 40, "I AM SPARTACUS!", 9000); 
     warriors[1] = new Warrior("Crixus", 35, "CHAMPION OF CAPUA", 8000); 
     warriors[2] = new Warrior("Gannicus", 30, "SLAYER OF VAGINAS", 8000); 
     warriors[3] = new Warrior("Alexander", 21, "I AM ALEXANDER, THE CODER", 0); 
    } 

    // getters and setters 
} 

Answer 2

我不会重复为StackOverflow异常的原因，因为这已经被回答了（在你的构造函数中递归问题）。

但是，我认为，你可能想要的是那些创建4级特殊的战士一次而不是一个Warrior的每个实例。也许你想以某种方式让它们成为常量。

因此，也许是这样的：

public class Warrior { 

    private static final List<Warrior> MEGA_WARRIORS = 
     Collections.unmodifiableList(Arrays.asList(
      new Warrior("Spartacus", 40, "I AM SPARTACUS!", 9000), 
      new Warrior("Crixus", 35, "CHAMPION OF CAPUA", 8000), 
      new Warrior("Gannicus", 30, "SLAYER OF *censored*", 8000), 
      new Warrior("Alexander", 21, "I AM ALEXANDER, THE CODER", 0) 
     )); 

    public static List<Warrior> getMegaWarriors() { 
     return MEGA_WARRIORS; 
    } 

    private String name; 
    private int age; 
    private String call; 
    private int attackPower; 
    private String weapon; 

    public Warrior(String myName, int myAge, String myCall, int myAttackPower) { 
     name = myName; 
     age = myAge; 
     call = myCall; 
     attackPower = myAttackPower; 
     weapon = ""; 
    } 

    //Prints warriors name 
    public void name() { 
     System.out.println(name); 
    } 

    //Prints warriors age 
    public void age() { 
     System.out.println(age); 
    } 

    //Prints warriors call 
    public void warriorsCall() { 
     System.out.println(call); 
    } 

    //Prints warriors attack power 
    public void attackPower() { 
     System.out.println(attackPower); 
    } 

    //Equips warriors weapon and prints message 
    public void equip(String myWeapon) { 
     weapon = myWeapon; 
     System.out.println("Equiped the: " + weapon); 
    } 

    //Prints warriors weapon 
    public void weapon() { 
     System.out.println(weapon); 
    } 

}